-
Notifications
You must be signed in to change notification settings - Fork 15
OpenCode v1.1.48 #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenCode v1.1.48 #118
Conversation
Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
- Add Skill.content() method to load skill template content from SKILL.md files - Modify Command.list() to include skills as invokable commands - Add 'skill' boolean property to Command.Info schema - Update autocomplete to show skills with (Skill) label in slash commands - Regenerate SDK to include skill property in Command type
This reverts commit 8512655.
…lot reasoning tokens (#8900) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com> Co-authored-by: Aiden Cline <aidenpcline@gmail.com>
… instead of waiting for hourly schedule
Users can now configure their own models configuration file by setting the OPENCODE_MODELS_PATH environment variable, providing more flexibility for testing and configuration.
…#11168)" (#11461) Co-authored-by: adamelmore <2363879+adamdottv@users.noreply.github.com>
|
OC disables sharing for some tests, most likely they set the env var somewhere where we don't set it and that makes the unit tests red? |
marius-kilocode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, obv we should fix the tests
packages/app/e2e/fixtures.ts
Outdated
| localStorage.setItem( | ||
| "opencode.global.dat:model", | ||
| JSON.stringify({ | ||
| recent: [{ providerID: "opencode", modelID: "big-pickle" }], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this could break the tests, we need a kilo model for the e2e tests. And a fixture would need to mirror that.
| @starting-style { | ||
| animation: none; | ||
| } | ||
| z-index: 60; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARNING: select-content no longer opts out of pointer events / hide animation when closed
This diff removes the previous pointer-events: none + hide animation approach for the closed state, but the new CSS doesn’t add an explicit closed-state hide (e.g. display: none / visibility: hidden). If Kobalte’s Select.Content remains mounted while closed, the content may still be focusable/clickable or briefly visible. Please verify the closed dropdown cannot be interacted with and is correctly hidden across browsers.
Code Review SummaryStatus: 3 Issues Found | Recommendation: Address before merge Fix these issues in Kilo Cloud Overview
Issue Details (click to expand)WARNING
SUGGESTION
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (15 files)
|
| types: [opened, synchronize, labeled, unlabeled] | ||
| workflow_dispatch: | ||
| schedule: | ||
| - cron: "0 * * * *" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARNING: Hourly schedule will still create workflow runs even though the job is disabled
on.schedule triggers a workflow run every hour (0 * * * *) regardless of jobs.sync.if: false. Even with the job skipped, this can clutter Actions history and may count toward workflow-run limits. Consider removing the schedule while the job is disabled, or making it less frequent until the sync is re-enabled.
.github/workflows/test.yml
Outdated
| env: | ||
| KILO_API_KEY: ${{ secrets.KILO_API_KEY }} | ||
| KILO_ORG_ID: ${{ secrets.KILO_ORG_ID }} | ||
| OPENCODE_DISABLE_SHARE: "false" # kilocode_change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CRITICAL: OPENCODE_DISABLE_SHARE set to "false" will un-skip share E2E and may enable outbound share sync
packages/app/e2e/session/session.spec.ts skips share tests only when OPENCODE_DISABLE_SHARE is true/1, and packages/opencode/src/share/share-next.ts uses the same env var to decide whether to sync. With KILO_DISABLE_SHARE: "true" still set, this combination is likely inconsistent (share UI/behavior disabled, but share tests enabled and/or server sync enabled), which can break CI or leak session data.
| OPENCODE_DISABLE_SHARE: "false" # kilocode_change | |
| OPENCODE_DISABLE_SHARE: "true" # kilocode_change |
| OUTPUT_TOKEN_MAX, | ||
| ) | ||
| const maxOutputTokens = | ||
| isCodex || provider.id.includes("github-copilot") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SUGGESTION: includes("github-copilot") may match unintended provider IDs
Using includes here can disable maxOutputTokens for any provider whose ID happens to contain the substring (including custom/self-hosted IDs). startsWith("github-copilot") is a tighter match while still covering github-copilot-enterprise.
| isCodex || provider.id.includes("github-copilot") | |
| isCodex || provider.id.startsWith("github-copilot") |
https://github.com/anomalyco/opencode/releases/tag/v1.1.48
Core
Desktop
Thank you to 7 community contributors: